jacob/munch-ease-frontend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
munch-ease-frontend/frontend-spec.md

20 KiB
Raw Blame History

0. Current State (Nov 1, 2025)

All core features are migrated to multi-tenancy with path-scoped endpoints and token-based auth. The codebase no longer uses the X-Household-Slug header. Tests and type checks are fully green.

0. Current State (Nov 1, 2025)

All core features are migrated to multi-tenancy with path-scoped endpoints and token-based auth. The codebase no longer uses the X-Household-Slug header. Tests and type checks are fully green.

Status of tests and typing

  • All tests pass: 27 files, 46 tests (slug-only routes; memory history fallback in non-browser envs; unauthenticated and refresh-401 guard redirects covered).
  • tsc and vue-tsc pass with no errors.

Frontend Specification: Household Multi-Tenancy (v2)

1. Objective

Transition the frontend from a single-tenant application to a multi-tenant one centered around the concept of "Households". This involves refactoring the existing authentication system, user onboarding, and data presentation to ensure all information (recipes, meals, shopping lists) is scoped to the active household.

This plan is adapted to the existing codebase, focusing on refactoring rather than starting from scratch.

2. Core Concepts

  • Household: A private group of users. All data is isolated and only visible to members of that household.
  • URL-based Tenancy: The active household is determined by the URL, e.g., /the-smiths/recipes. This makes household context explicit and shareable.
  • Household Switching: Users belonging to multiple households can switch between them.
  • Authentication: Evolve the existing system from a simple username login to a robust one supporting email/password and Google OAuth, using JWTs.

3. User Flows & UI Requirements

3.1. Authentication & Onboarding

  • Login Page (/login):
    • Refactor src/components/LoginPage.vue.
    • Replace the current username input with:
      • Email & Password login fields.
      • A "Sign in with Google" button.
    • Add a link to the "Create Account" page (/create-account).
  • Create Account Page (/create-account):
    • Create a new view src/views/CreateAccount.vue.
    • UI components for:
      • Email, Display Name, and Password input.
      • "Sign up with Google" button.
      • A link back to the "Login" page.
  • Post-Login Household Selection (/welcome):
    • Create a new view src/views/Welcome.vue.
    • After a new user logs in for the first time, they are directed here.
    • The page should present two choices:
      1. Create a new household: A simple form with "Household Name".
      2. Join an existing household: This section should clearly state: "To join a household, ask an existing member to send an invitation to your email address."
  • Invitation Flow:
    • A user receives an email with a link like https://<app-domain>/invitations/accept?token=....
    • Visiting this link while logged in should add them to the household and redirect them to that household's dashboard.

3.2. In-App Experience

  • Household-Scoped URLs:
    • All application routes must be nested under a household slug: /:householdSlug/recipes, /:householdSlug/shopping, etc.
    • The router must be updated to handle this dynamic parameter. The householdSlug will be used in all API calls to fetch household-specific data.
  • Household Switcher:
    • Create a new component src/components/HouseholdSwitcher.vue.
    • Place it in a prominent location (e.g., inside App.vue's navigation bar).
    • It should list all households the current user is a member of.
    • Clicking a household name should navigate the user to the dashboard of that household, e.g., /<new-household-slug>/dashboard.
  • Invite Members UI:
    • Create a new view src/views/HouseholdSettings.vue.
    • It should be accessible at /:householdSlug/settings/members.
    • It should contain a simple form to enter an email address and a button to "Send Invitation".
    • It should also list current household members.

4. Actionable Implementation Steps

  1. [x] Refactor Authentication State & API:
    • Modify src/api/auth.ts:
      • Implemented JWT-based login/register using new endpoints; Authorization header injected via client provider.
      • loginWithPassword(email, password) and createAccount(email, displayName, password) now return User and set token.
      • logout() clears token and cached user.
  • currentUser() now performs token-only refresh (no user in response) and then loads user context via /api/v1/users/me/households.
    • Modify src/composables/useAuth.ts:
      • Updated to use User, added loginWithPassword + logout, and state for households + activeHousehold.
      • Added fetchHouseholds() which hits /api/v1/users/me/households and stores state.
  1. [x] Update Router for Multi-Tenancy:
    • Modify src/router/index.ts:
      • Added new public routes: /create-account, /welcome, and /invitations/accept.
      • Removed legacy flag and flat routes: feature routes are always nested under /:householdSlug/....
      • Refactor the beforeEach guard:
        • Allows public routes.
        • After auth, fetches households via useAuth().fetchHouseholds().
        • If none: redirect to /welcome.
        • If at root (/): redirect to first household's /:householdSlug/mealplan.
        • Ensures activeHousehold is set when navigating within a household.
  • Nest existing routes: Always under /:householdSlug (legacy flat routes removed).
  • History behavior: Uses hash history in real browsers and memory history in tests/SSR (detected via globalThis.location). Router tests assert slug-only mode.
  1. [~] Implement Onboarding and Invitation Flows:
    • Build the Welcome.vue view for creating the first household.
    • Build the CreateAccount.vue view.
    • Build the "Accept Invitation" page (/invitations/accept?token=...). It should take the token from the URL, call the API, and redirect on success.
  • Status: Welcome page implements create-household flow using POST /api/v1/households and redirects to /:slug/mealplan. Create Account UI implemented. Invitation Accept implemented: reads token from query, calls typed POST /api/v1/invitations/accept, and redirects to the accepted household.

  1. [~] Integrate Household Context into the App:

    • Create src/composables/useHousehold.ts: Implemented. Extracts householdSlug from route and binds provider to API client.
    • Implement HouseholdSwitcher.vue: Implemented minimal version and mounted in App.vue.
    • Update API Services: No household header injection; Authorization header provided by token provider. Cookies are only sent for the refresh endpoint; all other requests avoid credentials. SDK/services use typed path params.
      • Verified by tests/household.header.test.ts, auth tests, and router guard tests.

  2. [~] Implement Invitation UI:

  • Build the HouseholdSettings.vue view for inviting members and listing current members.
  • Status: Invite form implemented (sends email via POST /api/v1/invitations). Members listing implemented using typed endpoint GET /api/v1/households/{householdSlug}/members.
  1. [ ] Final Review & Cleanup:
    • Remove the old persons concept from the frontend code. The user from useAuth is now the primary identity.
    • Ensure all data displays are correctly filtered by the active household by verifying the householdSlug is passed in all API calls.
    • Test all user flows: new user signup, login, creating a household, joining via invitation, and switching between households.

0. Current State (Nov 1, 2025)

All core features are migrated to multi-tenancy with path-scoped endpoints and token-based auth. The codebase no longer uses the X-Household-Slug header. Tests and type checks are fully green.

What exists now

  • Auth
    • src/api/auth.ts: email/password login and register; token-only refresh in currentUser() which then loads /api/v1/users/me/households.
    • src/composables/useAuth.ts: manages user, households, and activeHousehold; exposes login/logout/createAccount and fetchHouseholds().
  • Routing
    • src/router/index.ts: slug-only nesting under /:householdSlug/...; public routes include /create-account, /welcome, and /invitations/accept.
    • Guard fetches households, redirects root / to the first household's mealplan, and uses memory history in tests (hash in browser).
  • SDK/API
    • src/api/sdk.ts: recipes, meals, and shopping are migrated to /api/v1/households/{householdSlug}/... typed endpoints. Person endpoints removed; parse uses a temporary raw fetch endpoint until typed coverage is available.
    • src/api/client.ts: Authorization header provider only; household header injection removed.
  • Domain & UI
    • Member arrays (chefs, consumers, cleanup) normalized to MemberRef { id, displayName } with decoders handling legacy shapes gracefully.
    • MemberRef is exported from src/domain/types.ts and used by components (per axioms).
    • PersonList.vue renamed to MemberList.vue; it sources from typed household members and emits add/remove.
    • Invitation Accept flow implemented; Household Settings supports sending invitations and listing members using typed endpoints.
    • MyShopping: page remains as in master with editable panel backed by legacy v1 stubs (getMyShoppingList/saveMyShoppingList) pending backend ad-hoc item endpoints.

Status of tests and typing

  • All tests pass: 27 files, 46 tests.
  • tsc and vue-tsc pass with no errors.

Amendment: API Services and Typing Strategy (Updated Nov 1, 2025)

The backend OpenAPI has been updated and now exposes householdSlug as a path parameter for scoped endpoints (recipes, meals, shopping, invitations, whoami). Auth endpoints are fully typed (login/register/refresh/logout). Invitation acceptance remains a global endpoint (/api/v1/invitations/accept) with a typed operation.

Implications and actions (completed):

  • Removed X-Household-Slug and migrated to typed path parameters across recipes, meals, and shopping.
  • currentUser() updated to token-only refresh and household loading.
  • Invitations: sending is typed under household scope; accept is typed globally.
  • Members listing is now typed under GET /api/v1/households/{householdSlug}/members; UI updated to display displayName and role.

Progress Log (Nov 1, 2025)

  • Established green baseline (typecheck + tests pass).
  • Added auth API tests driving a minimal multitenant-ready surface.
  • Implemented loginWithPassword, logout, and stubs in src/api/auth.ts to satisfy tests.
  • Refactored useAuth to add households and activeHousehold state, plus loginWithPassword and logout. Tests added and passing.
  • Added router tests and implemented slug-only nested routes and new public routes. Placeholders for onboarding/invitations added.
  • Implemented useHousehold.ts, Authorization provider in API client, minimal HouseholdSwitcher.vue, and mounted it. Replaced header injection test with path-scoped assertion.
  • Implemented JWT login/register in auth.ts and wired token to client provider. useAuth updated with households fetching. currentUser refactored to token-only refresh plus households load.
  • Router guard updated to handle public/multitenant routing and redirects.
  • Added useAuth.createAccount with state update and tests for it; implemented CreateAccount.vue with form and navigation.
  • Implemented Invitation Accept flow: added src/api/invitations.ts with typed acceptInvitation, InvitationAccept.vue reads token and redirects to household; added tests/invitations.api.test.ts.
  • Next: Implement Household Settings (invite members form), then remove legacy Person UI.
  • Added a Settings link to HouseholdSwitcher.vue to surface the household-settings route for easier discovery.
  • Implemented Household Settings invite form and members list UI. src/views/HouseholdSettings.vue now loads members via the typed endpoint.
  • Router uses memory history in tests to avoid relying on window.location. Added unauthenticated and refresh-401 guard redirect tests.
  • Backend updated OpenAPI and codegen has been run:
    • Many endpoints are now path-scoped with {householdSlug} (recipes, meals, shopping, invitations (create), whoami).
    • Auth endpoints (login/register/refresh/logout) are fully typed; refresh returns only { accessToken, tokenType }.
  • Completed migration to typed path parameters; header injection removed; only small raw fetch helpers remain for endpoints not yet in OpenAPI (parse only).

Refinements (Nov 1, 2025, later):

  • Lint hardening: removed remaining as any and unsafe assertions across SDK/decoders.
  • decodeRecipe/decodeMeal simplified to use concrete OpenAPI shapes and defaults; legacy Person normalization removed.
  • Raw parse endpoints now use small runtime guards and normalize to strict RecipeOut before decoding.
  • UI polish: MemberList and EditMealPage CSS class names unified (person-* → member-*). Login page shows a Google sign-in button wired to the placeholder handler.

Detailed Tasks by File/Module

New files

  • src/views/CreateAccount.vue: Email, Display Name, Password; Google signup; link to login.
  • src/views/Welcome.vue: Create first household or instructions to join via invite.
  • src/views/HouseholdSettings.vue: Invite members by email; list members.
  • src/components/HouseholdSwitcher.vue: Lists user households and navigates to selected household dashboard.
  • src/composables/useHousehold.ts: Exposes activeHouseholdSlug from route and small helpers.

Auth

  • src/api/auth.ts:
    • Replace login(username: string) → login(email: string, password: string).
    • Add createAccount, handleGoogleLogin, logout; update currentUser to refresh JWT/session.
    • Store token per backend guidance; clear on logout.
  • src/composables/useAuth.ts:
    • Manage user, households, activeHousehold state; expose login, register, handleGoogleLogin, logout, loadUser, setActiveHousehold.

Router

  • src/router/index.ts:
    • Add public routes: /create-account, /welcome, /invitations/accept.
    • Nest feature routes under /:householdSlug.
    • Guard: after auth, fetch households; redirect root / to first household dashboard; route /welcome if none.
    • Update imperative navigations to include { householdSlug } via named routes.

API client

  • src/api/client.ts:
    • Uses typed { params: { path: { householdSlug } } } across SDK; X-Household-Slug header provider removed.
    • Authorization provider remains as-is, fed by JWT token from login/refresh.

SDK

  • src/api/sdk.ts:
    • Recipes, meals, shopping fully path-scoped to households.
    • Newly typed endpoints (post-latest codegen):
      • GET /api/v1/households/{householdSlug}/shopping/current — current aggregated list.
      • GET /api/v1/households/{householdSlug}/shopping/{list_id} — purchased list by id.
      • POST /api/v1/households/{householdSlug}/shopping — purchase items (storeName + items).
      • POST /api/v1/households/{householdSlug}/shopping/current/meals/me — request a meal.
      • DELETE /api/v1/households/{householdSlug}/shopping/current/meals/{meal_id} — unrequest a meal.
      • POST /api/v1/households/{householdSlug}/shopping/current/ingredients — request an ingredient (by id) for shopping.
    • Persons and parse endpoints are still raw until they are added to the OpenAPI.

UI

  • Login Page: Refactored to show email/password form; Google sign-in planned. Link to Create Account added.
  • Add HouseholdSwitcher.vue to app chrome and wire with router.
  • Update components that navigate using string paths to use named routes with slug.
  • src/views/HouseholdSettings.vue: Invite members form wired to sendInvitation(email). Members list rendered from listMembers() using the typed endpoint. (Completed)
  • Adjust pages that call SDK/API to pass { householdSlug } path params once client services are migrated.

Tests

  • MSW handlers updated for path-scoped endpoints; Authorization header assertions retained where relevant.
  • Router tests run under memory history.
  • Replaced header injection test with path-scoped recipe list test.

OpenAPI & Typing Considerations (Updated)

  • Avoid any/unknown in app code; keep all API calls typed via openapi-fetch.
  • Household scoping: use typed path params ({ params: { path: { householdSlug } } }); do not mutate path strings.
  • Auth refresh: returns { accessToken, tokenType }. After refresh, call user/household endpoints to populate app state. Use whoami to validate the active route’s slug when needed.
  • Cleanup/migration tasks:
    1. Remove X-Household-Slug header injection in api/client.ts and refactor services to accept householdSlug via typed params. (Completed)
    2. Replace temporary raw fetch calls with generated typed endpoints where available: invitations and members listing are now typed; migrate usages. Persons and parse remain raw for now.
    3. Integrate the new POST /shopping/current/ingredients endpoint into the SDK (requestIngredient(ingredientId: number)) and expose via useShopping; refactor MyShoppingPage.vue accordingly and remove legacy stubs. (SDK + composable done; UI refactor next)
    4. Identity: User remains the primary identity. Person has been removed; meal-related UIs use MemberRef exclusively.

Migration Plan & Feature Flag

  • Removed VUE_APP_MULTITENANT_ENABLED and legacy flat routes. The app now always uses slug-scoped routes.

Acceptance Criteria (Summary)

  • Users can create accounts, login (email/password), logout, and refresh sessions (token-only).
  • All routes operate under /:householdSlug with correct redirects and deep link support.
  • Active household is selectable and visible; API calls are correctly scoped via path params.
  • Invitation token acceptance adds membership and navigates appropriately.
  • Legacy persons identity is no longer used in auth; MemberRef used in meal UIs; tests updated and passing.

Google OAuth is planned next.

Open Questions / Next Steps

  • Add a user profile endpoint and load it post-refresh to populate currentUser() with real data instead of a placeholder.
  • Replace temporary raw fetch calls (persons, parse, members listing) with typed endpoints when available.
  • Implement Google OAuth login and account creation flows.
  • MyShopping ad-hoc item requests (planned):
    • The v2 OpenAPI spec is being updated to include endpoints for creating, listing, updating, and deleting ad-hoc requested items on the current shopping list (independent of meals), scoped under /api/v1/households/{householdSlug}/shopping/current/items.
    • Once available, add typed SDK methods:
      • createRequestedItem(input: { name: string; line?: string; quantity?: number; unit?: Unit })
      • updateRequestedItem(id: number, patch: { name?: string; line?: string; quantity?: number; unit?: Unit })
      • deleteRequestedItem(id: number)
      • listRequestedItems() (if provided separately; otherwise rely on getCurrentShoppingList())
    • Refactor src/components/shopping/MyShoppingPage.vue to use the above methods and remove legacy stubs getMyShoppingList/saveMyShoppingList from the SDK and useShopping composable.
    • Update tests to drive TDD:
      • MSW handlers for the new endpoints with path-scoped URLs and Authorization.
      • Component tests to add, edit, and delete an ad-hoc requested item and verify it appears under outstanding items in getCurrentShoppingList().
    • Acceptance criteria:
      • Users can add an item without associating it to a meal.
      • Users can edit and delete such items.
      • All calls use typed path-scoped endpoints; no header injection; Authorization still via provider.
    • Note: No temporary measures required; proceed directly once backend ships endpoints.
    • Current status: Legacy stubs removed from composable; MyShoppingPage.vue simplified around requestIngredient; shape test added and passing. Full ad-hoc CRUD UI awaits backend endpoints.
  • Remove the legacy username login shim (login(username: string)) and any fallback UI; standardize on email/password (and Google) only.
  • Rollout flag: default VUE_APP_MULTITENANT_ENABLED to true across environments and plan removal of legacy flat routes and related tests once stable.