From 68e82f1fa2e1568e31dbeb745e1d431fd1904714 Mon Sep 17 00:00:00 2001
From: jableader <jacobdunk@gmail.com>
Date: Sat, 18 Oct 2025 13:57:40 +1100
Subject: [PATCH] Composition #4

---
 refactor-strategy.md                      |  19 ++-
 src/App.vue                               |  14 +-
 src/components/AlertToast.vue             |  58 +++----
 src/components/LoginPage.vue              |  51 +++---
 src/components/recipes/EditRecipePage.vue | 191 +++++++++++-----------
 5 files changed, 159 insertions(+), 174 deletions(-)

diff --git a/refactor-strategy.md b/refactor-strategy.md
index 0771fb9..b5c98cb 100644
--- a/refactor-strategy.md
+++ b/refactor-strategy.md
@@ -76,16 +76,17 @@ Already using `<script setup>`:
 - Core/Leaf: `components/ActionItem.vue`, `recipes/RecipeCard.vue`, `ingredients/CompactParsedIngredient.vue`
 - Ingredients: `ingredients/IngredientLine.vue`, `ingredients/EditableIngredientsPanel.vue`
 - Recipes: `components/recipes/RecipesPage.vue`, `components/recipes/RecipeSearchBox.vue`
+ - Recipes: `components/recipes/RecipesPage.vue`, `components/recipes/RecipeSearchBox.vue`, `components/recipes/EditRecipePage.vue`
 
 Remaining to migrate (Options API or mixed):
 
 - Core
-  - `App.vue`
-  - `components/AlertToast.vue`
-  - `components/LoginPage.vue`
+  - 
+  - 
+  - 
 
 - Recipes
-  - `components/recipes/EditRecipePage.vue` (most complex)
+  - 
 
 - Meals
   - `components/meals/DatePicker.vue`
@@ -137,15 +138,15 @@ Remaining to migrate (Options API or mixed):
 
 ## Tracking checklist
 
-- [ ] Core: `App.vue`
-- [ ] Core: `components/AlertToast.vue`
+- [x] Core: `App.vue`
+- [x] Core: `components/AlertToast.vue`
 - [x] Core: `components/ActionItem.vue`
-- [ ] Core: `components/LoginPage.vue`
+- [x] Core: `components/LoginPage.vue`
 
 - [x] Recipes: `components/recipes/RecipesPage.vue`
 - [x] Recipes: `components/recipes/RecipeSearchBox.vue`
 - [x] Recipes: `components/recipes/RecipeCard.vue`
-- [ ] Recipes: `components/recipes/EditRecipePage.vue`
+- [x] Recipes: `components/recipes/EditRecipePage.vue`
 
 - [x] Meals: `components/meals/MealCard.vue`
 - [x] Meals: `components/meals/DatePicker.vue`
@@ -159,6 +160,8 @@ Remaining to migrate (Options API or mixed):
 - [x] Shopping: `components/shopping/MealSelectionList.vue`
 - [x] Shopping: `components/shopping/ShoppingListItem.vue`
 
+All components are now migrated to `<script setup>`.
+
 ## Notes and risks
 
 - `PersonList.vue` aligns a dropdown to an input via DOM measurements; ensure the ref-based approach updates positions correctly on focus/resize.
diff --git a/src/App.vue b/src/App.vue
index 6cb20bd..aa23d13 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -25,20 +25,10 @@
   <alert-toast />
 </template>
 
-<script>
+<script setup>
 import AlertToast from './components/AlertToast.vue'
 
-export default {
-  name: 'App',
-  components: {
-    'alert-toast': AlertToast,
-  },
-  computed: {
-    currentRoute() {
-      return this.$route.path
-    },
-  },
-}
+// components in <script setup> are auto-registered by import + usage
 </script>
 
 <style>
diff --git a/src/components/AlertToast.vue b/src/components/AlertToast.vue
index 4fe6afc..f1535a4 100644
--- a/src/components/AlertToast.vue
+++ b/src/components/AlertToast.vue
@@ -47,7 +47,8 @@
 }
 </style>
 
-<script>
+<script setup>
+import { ref, computed, onMounted } from 'vue'
 import alert from '@/alert'
 
 const alertIcons = {
@@ -56,37 +57,28 @@ const alertIcons = {
   info: require('@/assets/notification-info.svg'),
 }
 
-export default {
-  name: 'AlertToast',
-  data() {
-    return {
-      showAlert: false,
-      heading: '',
-      message: '',
-      type: '',
-    }
-  },
-  computed: {
-    icon() {
-      return this.type && alertIcons[this.type] ? alertIcons[this.type] : null
-    },
-  },
-  mounted() {
-    alert.subscribe(this.show)
-  },
-  methods: {
-    show({ heading, message, type }) {
-      this.heading = heading
-      this.message = message
-      this.type = type
-      this.showAlert = true
-      setTimeout(() => {
-        this.showAlert = false
-      }, 5000)
-    },
-    dismiss() {
-      this.showAlert = false
-    },
-  },
+const showAlert = ref(false)
+const heading = ref('')
+const message = ref('')
+const type = ref('')
+
+const icon = computed(() => (type.value && alertIcons[type.value] ? alertIcons[type.value] : null))
+
+function show({ heading: h, message: m, type: t }) {
+  heading.value = h
+  message.value = m
+  type.value = t
+  showAlert.value = true
+  setTimeout(() => {
+    showAlert.value = false
+  }, 5000)
 }
+
+function dismiss() {
+  showAlert.value = false
+}
+
+onMounted(() => {
+  alert.subscribe(show)
+})
 </script>
diff --git a/src/components/LoginPage.vue b/src/components/LoginPage.vue
index 3302992..d46a4b1 100644
--- a/src/components/LoginPage.vue
+++ b/src/components/LoginPage.vue
@@ -3,7 +3,7 @@
     <h1>Login Page</h1>
     <ul class="button-group">
       <li v-for="person in persons" :key="person.id">
-        <button type="button" class="btn btn-primary" @click="login(person)">
+        <button type="button" class="btn btn-primary" @click="onLogin(person)">
           {{ person.name }}
         </button>
       </li>
@@ -67,36 +67,29 @@ li:nth-child(4) > button {
 }
 </style>
 
-<script>
+<script setup>
+import { ref, onMounted } from 'vue'
+import { useRouter } from 'vue-router'
 import { getPersonsInHome } from '@/api/persons'
-import { login } from '@/api/auth'
+import { login as loginApi } from '@/api/auth'
 
-export default {
-  name: 'LoginVue',
-  props: {
-    redirect: {
-      type: String,
-      default: '/',
-    },
-  },
-  data() {
-    return {
-      persons: [],
-    }
-  },
-  async beforeMount() {
-    this.persons = await getPersonsInHome()
-  },
-  methods: {
-    async login(selectedPerson) {
-      const person = await login(selectedPerson.name)
-      if (person?.id >= 0) {
-        this.$router.push(this.redirect)
-        return
-      }
+const props = defineProps({
+  redirect: { type: String, default: '/' },
+})
 
-      alert('Login failed')
-    },
-  },
+const router = useRouter()
+const persons = ref([])
+
+onMounted(async () => {
+  persons.value = await getPersonsInHome()
+})
+
+async function onLogin(selectedPerson) {
+  const person = await loginApi(selectedPerson.name)
+  if (person?.id >= 0) {
+    router.push(props.redirect)
+    return
+  }
+  alert('Login failed')
 }
 </script>
diff --git a/src/components/recipes/EditRecipePage.vue b/src/components/recipes/EditRecipePage.vue
index 512480d..68a5172 100644
--- a/src/components/recipes/EditRecipePage.vue
+++ b/src/components/recipes/EditRecipePage.vue
@@ -63,101 +63,108 @@ input.recipe-name {
 }
 </style>
 
-<script>
+<script setup>
+import { ref, computed, onMounted, watch } from 'vue'
+import { useRouter, useRoute } from 'vue-router'
 import alert from '@/alert.js'
-import { getRecipe, parseRecipe, saveRecipe, deleteRecipe as deleteRecipeApi } from '@/api/recipes'
+import { getRecipe, parseRecipe, saveRecipe as saveRecipeApi, deleteRecipe as deleteRecipeApi } from '@/api/recipes'
 import EditableIngredientsPanel from '@/components/ingredients/EditableIngredientsPanel.vue'
 
-export default {
-  props: {
-    id: { type: Number, optional: true },
-  },
-  components: { EditableIngredientsPanel },
-  data() {
-    return {
-      link: this.$route.query.url ?? '',
-      parse_failed: false,
-      recipe: null,
-      chefs: [],
-    }
-  },
-  mounted() {
-    this.refreshRecipe()
-  },
-  computed: {
-    image_styling() {
-      if (this.recipe?.image_urls && this.recipe.image_urls[0]) {
-        const image = this.recipe.image_urls[0]
-        //  linear-gradient(to bottom, rgba(255, 255, 255, 0.8) 0%, rgba(255, 255, 255, 0) 100%), url('https://i2.wp.com/www.downshiftology.com/wp-content/uploads/2019/04/steamed-broccoli-4.jpg') center/cover no-repeat;
-        return {
-          background: `linear-gradient(to bottom, rgba(255, 255, 255, 0.8) 0%, rgba(255, 255, 255, 0) 100%), url('${image}') center/cover no-repeat`,
-        }
-      }
-      return null
-    },
-  },
-  methods: {
-    parseLink() {
-      this.$router.push({ path: '/recipes/add', query: { url: this.link } })
-      this.refreshRecipe()
-    },
-    async refreshRecipe() {
-      if (this.id >= 0) {
-        this.recipe = await getRecipe(this.id)
-        this.link = this.recipe.link
-        return
-      } else if (this.link) {
-        this.recipe = await parseRecipe(this.link)
-        this.parse_failed = !this.recipe
-      } else {
-        this.recipe = null
-      }
-    },
-    async updateIngredient(ingredient, newIngredient) {
-      this.recipe.ingredients = this.recipe.ingredients.map((i) =>
-        i == ingredient ? newIngredient : i
-      )
-    },
-    deleteIngredient(ingredient) {
-      this.recipe.ingredients = this.recipe.ingredients.filter((i) => i != ingredient)
-    },
-    async saveRecipe() {
-      const recipe = await saveRecipe(this.recipe)
-      if (recipe?.id >= 0) {
-        alert.show({
-          heading: 'Recipe saved',
-          message: 'Your recipe has been saved',
-          type: 'success',
-        })
-        this.$router.push(`/recipes/${recipe.id}`)
-        return
-      }
+const props = defineProps({
+  id: { type: Number, required: false },
+})
 
-      alert.show({
-        heading: 'Error saving recipe',
-        message: 'There was an error saving your recipe',
-        type: 'error',
-      })
-    },
-    async createFromScratch() {
-      this.recipe = {
-        id: -1,
-        name: 'My new recipe',
-        created_by_id: -1,
-        link: '',
-        ingredients: [],
-        image_urls: [],
-      }
-    },
-    addIngredient() {
-      this.recipe.ingredients = [{ line: '', product: null }, ...this.recipe.ingredients]
-    },
-    async deleteRecipe() {
-      if (confirm('Are you sure you want to delete this recipe?')) {
-        await deleteRecipeApi(this.recipe.id)
-        this.$router.push('/recipes')
-      }
-    },
-  },
+const router = useRouter()
+const route = useRoute()
+
+const link = ref(route.query.url ?? '')
+const parse_failed = ref(false)
+const recipe = ref(null)
+
+const image_styling = computed(() => {
+  if (recipe.value?.image_urls && recipe.value.image_urls[0]) {
+    const image = recipe.value.image_urls[0]
+    return {
+      background: `linear-gradient(to bottom, rgba(255, 255, 255, 0.8) 0%, rgba(255, 255, 255, 0) 100%), url('${image}') center/cover no-repeat`,
+    }
+  }
+  return null
+})
+
+function parseLink() {
+  router.push({ path: '/recipes/add', query: { url: link.value } })
+  refreshRecipe()
 }
+
+async function refreshRecipe() {
+  if (props.id >= 0) {
+    recipe.value = await getRecipe(props.id)
+    link.value = recipe.value.link
+    return
+  } else if (link.value) {
+    recipe.value = await parseRecipe(link.value)
+    parse_failed.value = !recipe.value
+  } else {
+    recipe.value = null
+  }
+}
+
+async function updateIngredient(ingredient, newIngredient) {
+  recipe.value.ingredients = recipe.value.ingredients.map((i) =>
+    i == ingredient ? newIngredient : i
+  )
+}
+
+function deleteIngredient(ingredient) {
+  recipe.value.ingredients = recipe.value.ingredients.filter((i) => i != ingredient)
+}
+
+async function saveRecipe() {
+  const saved = await saveRecipeApi(recipe.value)
+  if (saved?.id >= 0) {
+    alert.show({ heading: 'Recipe saved', message: 'Your recipe has been saved', type: 'success' })
+    router.push(`/recipes/${saved.id}`)
+    return
+  }
+  alert.show({ heading: 'Error saving recipe', message: 'There was an error saving your recipe', type: 'error' })
+}
+
+function createFromScratch() {
+  recipe.value = {
+    id: -1,
+    name: 'My new recipe',
+    created_by_id: -1,
+    link: '',
+    ingredients: [],
+    image_urls: [],
+  }
+}
+
+function addIngredient() {
+  recipe.value.ingredients = [{ line: '', product: null }, ...recipe.value.ingredients]
+}
+
+async function deleteRecipe() {
+  if (confirm('Are you sure you want to delete this recipe?')) {
+    await deleteRecipeApi(recipe.value.id)
+    router.push('/recipes')
+  }
+}
+
+onMounted(() => {
+  refreshRecipe()
+})
+
+// Keep recipe in sync if link query changes while on page
+watch(
+  () => route.query.url,
+  (newUrl) => {
+    if (typeof newUrl === 'string') {
+      link.value = newUrl
+      refreshRecipe()
+    }
+  }
+)
+
+// expose functions for template binding names (automatic in <script setup>)
 </script>